Skip to content

fix(tui): draw the progress bar from apk's first package - #41

Merged
NovusEdge merged 1 commit into
mainfrom
fix-progress-bar-padding
Aug 10, 2026
Merged

fix(tui): draw the progress bar from apk's first package#41
NovusEdge merged 1 commit into
mainfrom
fix-progress-bar-padding

Conversation

@NovusEdge

Copy link
Copy Markdown
Owner

The install/apply progress bar stayed blank for the whole early part of a big install.

apk right-pads the done counter to the total's width, so early lines read ( 1/263). apkCountRe required a digit immediately after (, so it matched no line until the counter reached the total's digit count. On the 263-package xfce apply that meant no bar for the first 99 packages; the panel showed only the step and last log line. pacmanCountRe already tolerates the padding with \s*; apk's regex now does too.

Also helps the install phase, since setup-alpine's apk output pads the same way.

Test: added a padded-counter case to TestParseProgress.

apk right-pads the done counter to the total's width, so early lines read
(  1/263). apkCountRe required a digit right after (, so it matched no line
until the counter reached the total's digit count. On a 263-package apply
the bar stayed blank for the first 99 packages. \s* absorbs the padding,
matching what pacmanCountRe already does.
@NovusEdge NovusEdge added the tui Terminal UI: layout, styling, interaction label Aug 10, 2026
@NovusEdge NovusEdge self-assigned this Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@NovusEdge, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0d3d5160-ac68-4e0c-ac2e-475a064c1dc8

📥 Commits

Reviewing files that changed from the base of the PR and between ca2e2df and c35d323.

📒 Files selected for processing (2)
  • internal/tui/pkgprogress.go
  • internal/tui/pkgprogress_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NovusEdge
NovusEdge merged commit da5cf13 into main Aug 10, 2026
8 checks passed
@NovusEdge
NovusEdge deleted the fix-progress-bar-padding branch August 10, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tui Terminal UI: layout, styling, interaction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant